Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about consistency #17

Open
astrojuanlu opened this issue Dec 6, 2018 · 1 comment
Open

Think about consistency #17

astrojuanlu opened this issue Dec 6, 2018 · 1 comment

Comments

@astrojuanlu
Copy link
Contributor

#8 (comment)

This MR references satellites by name instead of satellite ID, so it changes the convention that we currently have. Although it is nice to be able to search this way, it creates an inconsistency that we better avoid. Or we keep using ids, or we change everything to names, or we support both transparently here.

@astrojuanlu
Copy link
Contributor Author

Being hit by this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant