Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default export for Node.js backwards compatibility #2008

Open
1 of 2 tasks
nex3 opened this issue Jun 9, 2023 · 0 comments
Open
1 of 2 tasks

Add a default export for Node.js backwards compatibility #2008

nex3 opened this issue Jun 9, 2023 · 0 comments
Labels
enhancement JavaScript Issues particular to the Node.js distribution
Milestone

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 9, 2023

Node.js allows ESM modules to import CJS files as though they used a default export, which means there's some amount of existing ESM usage of the sass package via import sass from 'sass'. However, with the browser support changes that landed in 1.63.0, we started providing explicit ESM exports that only work with our desired syntax of import * as sass from 'sass'. We should:

@nex3 nex3 added bug JavaScript Issues particular to the Node.js distribution labels Jun 9, 2023
@nex3 nex3 added this to the 2.0.0 milestone Jun 9, 2023
nex3 added a commit that referenced this issue Jun 9, 2023
nex3 added a commit that referenced this issue Jun 9, 2023
nex3 added a commit to sass/sass-site that referenced this issue Jun 10, 2023
PixnBits added a commit to americanexpress/one-app-cli that referenced this issue Jun 12, 2023
accidentally removed in 1.63.0 through 1.63.3, will be removed in 2.x
sass/dart-sass#2008
PixnBits added a commit to americanexpress/one-app-cli that referenced this issue Jun 12, 2023
accidentally removed in 1.63.0 through 1.63.3, will be removed in 2.x
sass/dart-sass#2008
nex3 added a commit that referenced this issue Jun 13, 2023
nex3 added a commit to sass/sass-site that referenced this issue Jun 13, 2023
@nex3 nex3 added enhancement and removed bug labels Jul 31, 2023
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
asaf400 pushed a commit to asaf400/ass-site that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement JavaScript Issues particular to the Node.js distribution
Projects
None yet
Development

No branches or pull requests

1 participant