fix: catch InvalidVersion instead of handling LegacyVersion
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegacyVersion was removed from packaging in version 22.0
finswimmer
force-pushed
the
drop-legacy-version
branch
from
5980c29
to
e9ff279
Compare
finswimmer
changed the title
InvalidVersion instead of handling LegacyVersion
|
BTW: Having a lower boundary for |
|
@finswimmer Hey thanks for opening this -- I just approved the test runner to run; as far as I know we are open to and appreciate these kind of changes. I recently came out of a 50 hour power outage so I am still a bit foggy and will check on this again soon. |
|
Sounds good @matteius 👍 Then I will prepare a series of PR to modernize the code base in the next days. But for now have a good holiday. |
|
Hey @matteius, any chance that you find some time to have a look on that PR? fin swimmer |
oz123
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LegacyVersionwas removed frompackagingin version22.0. (See: pypa/packaging#530)Resolves: #126