Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some APIs are unsound #18

Open
marysaka opened this issue Oct 11, 2021 · 1 comment
Open

Some APIs are unsound #18

marysaka opened this issue Oct 11, 2021 · 1 comment

Comments

@marysaka
Copy link

At the current time of writing, multiple APIs allows the user to pass (or receive) a pointer directly or indirectly (via a structure containing pointers).

Those APIs should at least been marked unsafe.

@sanpii sanpii mentioned this issue Oct 12, 2021
@sanpii
Copy link
Owner

sanpii commented Oct 13, 2021

Thank you for pointing there points.

I made a PR to fix that, but the snapshot list segfaults:

    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
[examples/snapshot.rs:5] c.snapshot_list() = [
    Snapshot {
        inner: 0x000055ccb4f98180,
        comment_pathname: Some(
            "/var/lib/lxc/apicontainer/snaps/snap4/comment",
        ),
        lxcpath: "/var/lib/lxc/apicontainer/snaps",
        name: "snap4",
        timestamp: "2021:10:13 07:59:15",
    },
    Snapshot {
        inner: 0x00007ffd4b9887b8,
        comment_pathname: None,
Erreur de segmentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants