Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs to match PSD-managed RabbitMQ #4403

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Oct 8, 2024

Closes #

Changes proposed in this pull request

Here's my attempt to explain a bit of the setup: https://ssg-confluence.internal.sanger.ac.uk/display/PSDPUB/PSD-managed+RabbitMQ+for+test+environments.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (5f422ad) to head (4d787f7).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4403      +/-   ##
===========================================
+ Coverage    86.40%   86.50%   +0.09%     
===========================================
  Files         1390     1390              
  Lines        29771    29771              
===========================================
+ Hits         25724    25753      +29     
+ Misses        4047     4018      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sdjmchattie sdjmchattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. Is this to move away from the ISG managed instance? I think I've missed some discussion related to this. Perhaps you can update me on Slack instead of in public.

@dasunpubudumal dasunpubudumal merged commit 6bb4976 into develop Oct 22, 2024
34 checks passed
@dasunpubudumal dasunpubudumal deleted the update-configs-to-use-local-rabbitmq branch October 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants