Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-157 - Soft delete of a location #797

Open
7 tasks
seenanair opened this issue Jun 21, 2024 · 6 comments
Open
7 tasks

Y24-157 - Soft delete of a location #797

seenanair opened this issue Jun 21, 2024 · 6 comments
Labels
enhancement Labware Destruction size:s Small - low effort & risk value:3 Value to the insitute is average

Comments

@seenanair
Copy link
Contributor

seenanair commented Jun 21, 2024

User story
As a LabWhere user, I would like to soft delete a location that may no longer be in use or is misspelled. This allows for a cleaner UI and avoids unnecessary location names dangling around.

Who are the primary contacts for this story
Tristram Bellerby

Acceptance criteria
To be considered successful the solution must allow:

  • Delete button should be visible next to a location on the locations page on Labwhere
  • Pressing the Delete button will prompt for confirmation.
  • If confirmed, the location is removed from the UI (but retained in the database)
  • Users should not allowed to scan labware in to soft-deleted locations
  • Allow scanning labware out of labware (in case they forgot to do it when the location was 'deleted').
  • Automatically scan-out any labware in a location when it's deleted (and tell the user we're doing so) (need to discuss wuith stakeholder whether they prefer any other options)
  • For soft deleting a location with child locations, ask for explicit confirmation from the user before deleting child locations too for e.g like get them to check a box next to all the ones they want to delete or something.
@seenanair seenanair added enhancement value:3 Value to the insitute is average labels Jun 21, 2024
@psd-issuer psd-issuer bot changed the title Soft delete of a location Y24-157 - Soft delete of a location Jun 21, 2024
@seenanair seenanair added the size:s Small - low effort & risk label Jun 21, 2024
@KatyTaylor
Copy link
Contributor

I guess that we should also prevent users from scanning labware into or out of locations that have been soft-deleted?

@TWJW-SANGER
Copy link

Just on Katy's point.
I can see the point of preventing or warning people scanning labware into a soft-deleted location.

I am less sure why we would prevent users scanning labware currently in a soft-deleted location out of it or into another location ?

If we did prevent them - what would we expect them to do next? What errors are we preventing?

@seenanair
Copy link
Contributor Author

@TWJW-SANGER @KatyTaylor Hmm, that brings up another question: should we allow deletion of locations with labware inside them or should we prompt users to move the labware elsewhere before deletion?

@KatyTaylor
Copy link
Contributor

And if you soft delete locations with other locations inside them, does it also soft delete the child locations?

@KatyTaylor
Copy link
Contributor

Scanning out:

  • I guess if they're scanning out it's because they forgot to do it when the location was 'deleted', so we could let them do it
  • Or, we could automatically scan-out any labware in a location when it's deleted (and tell the user we're doing so)
  • Or ask users to scan them elsewhere like Seena suggests - but this could cause issues as the users might not know what those labware are.

Scanning into another location:

  • Agreed we shouldn't prevent a labware being scanned into a different location, just because it's in a 'deleted' location for some reason.

Child locations:

  • I think we should ask for explicit confirmation from the user before deleting child locations too - like get them to check a box next to all the ones they want to delete or something

@seenanair
Copy link
Contributor Author

@KatyTaylor @TWJW-SANGER Updated story with your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Labware Destruction size:s Small - low effort & risk value:3 Value to the insitute is average
Projects
None yet
Development

No branches or pull requests

4 participants