Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histogram functionality to PS model #1129

Closed
alexsielicki opened this issue Jun 21, 2023 · 6 comments · Fixed by #1156
Closed

Add histogram functionality to PS model #1129

alexsielicki opened this issue Jun 21, 2023 · 6 comments · Fixed by #1156
Assignees
@alexsielicki
Labels
enhancement PS Model

Comments

@alexsielicki
Copy link
Collaborator

No description provided.

@alexsielicki alexsielicki self-assigned this Jun 21, 2023
alexsielicki added a commit that referenced this issue Jun 24, 2023
@alexsielicki
Adding optional params to each dropdown item so it can override the d…
6893ffc 
…ropdown's set_selected function and its selected item. Addresses #1129
alexsielicki added a commit that referenced this issue Jun 24, 2023
@alexsielicki
Customizing y-axis-dropdown to add functionality to display histogram…
b1be354 
…. Addresses #1129
alexsielicki added a commit that referenced this issue Jun 24, 2023
@alexsielicki
Hiding histogram when y variable is switched in table or dropdown. Ad…
8edd301 
…dresses #1129
@alexsielicki
Copy link
Collaborator Author

alexsielicki commented Jun 29, 2023 •
edited
Loading

After discussion with @smartin71, here's what left to do:

  • Use blue color for bars.
  • Support log scales.
  • Support Date & Time scales.
  • Support filtering.
  • Disable drop-downs that don't make sense (Point Color, Media, parts of Actions, Color, possibly others).
  • Clicking a histogram bar should select all associated rows in table. Allow selecting multiple bars in histogram.
  • Clicking row in table should flash associated histogram bar.
  • Support hidden points.
  • Support Auto Scale.
  • Support Variable Ranges.
  • Support Variable Alias Labels.
  • Support background grid.

Let me know if I missed anything @smartin71. I will add things if I remember more or run across anything else as I'm working on this.

@alexsielicki alexsielicki pinned this issue Jun 29, 2023
@alexsielicki
Copy link
Collaborator Author

alexsielicki commented Jul 13, 2023 •
edited
Loading

  • Figure out what to do about string variables

@alexsielicki
Copy link
Collaborator Author

alexsielicki commented Jul 13, 2023 •
edited
Loading

  • Make sure histogram width or height does not go to 0 or below, regardless of pane dimensions.

@alexsielicki
Copy link
Collaborator Author

  • Test with large data set. Specifically check for background scatterplot updates and if they're disrupting updates to histogram.

@alexsielicki
Copy link
Collaborator Author

alexsielicki commented Aug 14, 2023 •
edited
Loading

  • Display completely selected bars with solid bold border, and partially selected bars with dashed bold border.

@alexsielicki
Copy link
Collaborator Author

  • Fix auto scale for string date & time variables

@alexsielicki alexsielicki linked a pull request Jan 30, 2024 that will close this issue
Add histogram functionality #1156
Merged
@alexsielicki alexsielicki unpinned this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsielicki alexsielicki

Labels
enhancement PS Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add histogram functionality sandialabs/slycat
1 participant
@alexsielicki