Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error gen projection basis must be Basis object #455

Open
pcwysoc opened this issue Jun 21, 2024 · 1 comment
Open

Error gen projection basis must be Basis object #455

pcwysoc opened this issue Jun 21, 2024 · 1 comment
Assignees
Labels
bug A bug or regression
Milestone

Comments

@pcwysoc
Copy link

pcwysoc commented Jun 21, 2024

Describe the bug
Error generator projections require a Basis object and do not work with a basis name, i.e. 'pp'. This is not the expect behavior as listed in the documentation. The issue appears to be with how the errorgen_and_projections function in reportables.py handles basis information.

Screenshot 2024-06-21 at 1 51 18 PM

Environment (please complete the following information):

  • pyGSTi version feature-qiskit-mcm
  • python version 3.10
  • OS Ventura 13.6.7
@pcwysoc pcwysoc added the bug A bug or regression label Jun 21, 2024
@pcwysoc pcwysoc self-assigned this Jun 21, 2024
@pcwysoc pcwysoc changed the title Error generator basis bug Error gen projection basis must be Basis object Jun 21, 2024
@sserita
Copy link
Contributor

sserita commented Jun 21, 2024

This should be an easy fix, mx_basis needs a Basis.cast(mx_basis) prior accessing .name or something similar. We'll probs need to infer the dimension from the incoming errgen matrix.

@pcwysoc pcwysoc added this to the 0.9.13 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression
Projects
None yet
Development

No branches or pull requests

2 participants