Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing glove #178

Closed
afflerbach opened this issue Jun 30, 2024 · 4 comments
Closed

Missing glove #178

afflerbach opened this issue Jun 30, 2024 · 4 comments

Comments

@afflerbach
Copy link

afflerbach commented Jun 30, 2024

The left hand glove is missing on both the top-left male and muscular sprites.

The zombie and skeleton sprites are affected as well.

@jrconway3
Copy link

Thanks for pointing this out. I'll probably get to it eventually. Tbh, I think I'd like to map the gloves to all frames rather than just fix that one missing asset, but that would take a while and I slowed down a bit recently on updating these assets. I will get back to it sooner or later, though.

@jrconway3
Copy link

I waited long enough for this. I'll include this in the next batch of updates, I just wanted to finish #141 first. It shouldn't be too hard to redraw the gloves over all frames.

@jrconway3
Copy link

Yeah this shouldn't be too bad. Looks like there's only one type of gloves. IIRC, Muscular has an extra pixel depth so theoretically, it might be desirable to give them a separate set of gloves.

For now I am not worried about that, though. I'm going to prioritize finishing just male and female across all frames.

I just need to rotate the existing frames here and there for the new positions to figure how how the other hand positions should look, and then I can fine-tune where needed.

@jrconway3
Copy link

This should be done soon. However, I don't like the dark border between the gloves and the rest of the arm. I'm not going to remove it, I'm keeping this consistent. However, maybe eventually I might draw a variant with that removed, and also longer gloves as well that go partway up the arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants