Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias_method_chain is deprecated #1034

Open
dazza-codes opened this issue May 1, 2017 · 3 comments
Open

alias_method_chain is deprecated #1034

dazza-codes opened this issue May 1, 2017 · 3 comments

Comments

@dazza-codes
Copy link
Contributor

Descriptive summary

config/application.rb:8 generates a deprecation warning

Steps to reproduce the behavior

  1. Run a rake task, e.g.
$  bundle exec rake db:create
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /data/src/dlss/hydra/hyku/config/application.rb:8)
Created database 'development'
Created database 'test'
@jcoyne
Copy link
Member

jcoyne commented May 1, 2017

That's this issue: peek/peek-redis#3

@mjgiarlo
Copy link
Member

mjgiarlo commented May 1, 2017

Thanks for reporting this, @darrenleeweber. As far as I can tell, this deprecation warning is generated by one of Hyku's dependencies:

$ ag "alias_method_chain" $(bundle show --paths) .
/home/mjg/.rvm/gems/ruby-2.3.3@hyku/gems/oauth-0.5.1/lib/oauth/client/action_controller_request.rb
22:      alias_method_chain :process, :oauth

/home/mjg/.rvm/gems/ruby-2.3.3@hyku/gems/peek-sidekiq-1.0.3/lib/peek/views/sidekiq.rb
16:    alias_method_chain :push, :timing

/home/mjg/.rvm/gems/ruby-2.3.3@hyku/gems/sprockets-rails-3.2.0/lib/sprockets/rails/route_wrapper.rb
18:          alias_method_chain :internal?, :sprockets

/home/mjg/.rvm/gems/ruby-2.3.3@hyku/gems/zk-1.9.6/lib/zk/core_ext.rb
78:  unless method_defined?(:alias_method_chain)
79:    def alias_method_chain(target, feature)

@mjgiarlo mjgiarlo added this to the Backlog milestone May 1, 2017
@dazza-codes
Copy link
Contributor Author

It's not found in HyKu code, i.e.

$ git grep 'alias_method_chain'
# nothing found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants