brilift: Bump Cranelift dependency to v0.100.0 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which was released 9/20/2023. Surprisingly, everything just worked!
Brilift AOT didn't previously support macOS-on-ARM because `cranelift-object` didn't, which in turn is because the `object` crate was missing some relevant features. It seems like that support has been added, possibly in this PR but I'm not sure: gimli-rs/object#553 Anyway, stuff seems to be working on ARM now, which is cool. Now we can remove the hacks to insist on Rosetta2 when on Apple Silicon.
|
Just thought I'd include an updated, equally unreadable bar chart for the latest version running on my M1 Max MacBook Pro:
The average speedups are: I still don't think these are all that meaningful because so many of our benchmarks are extremely short-running (skewing things heavily in favor of AOT, for example), but that's a problem for another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a regular update to the latest version of Cranelift! This time, there was no API breakage. And in fact, it seems like, somewhere since the last time I updated things, Cranelift added support for AOT compilation (and
.ofile emission) on macOS-arm64. So we no longer need hacks to force things to run in Rosetta2 on Apple Silicon; I have taken these hacks out.