Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsDecreasing benchmark #280

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Add IsDecreasing benchmark #280

merged 3 commits into from
Sep 7, 2023

Conversation

NgaiJustin
Copy link
Contributor

No description provided.

Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good! I found one possibly out of date comment, and it would be awesome if you could help resolve the merge conflict.

@@ -0,0 +1,47 @@
# Input: an array of length 6
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this may be out of date? The input appears to be an integer, not an array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops good catch. Just fixed this!

@sampsyo
Copy link
Owner

sampsyo commented Sep 7, 2023

Excellent!

@sampsyo sampsyo merged commit 4eb7e00 into sampsyo:main Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants