Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple benchmark for if a rectangle fits inside another rectangle #269

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

bennyrubin
Copy link
Contributor

No description provided.

Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! This might win the prize for "smallest number of dynamic instructions in a benchmark." 😃 I have one documentation-related suggestion.

@@ -47,6 +47,7 @@ The current benchmarks are:
* `quadratic`: The [quadratic formula][qf], including a hand-rolled implementation of square root.
* `recfact`: Compute *n!* using recursive function calls.
* `rectangles-area-difference`: Output the difference between the areas of rectangles (as a positive value) given their respective side lengths.
* `rectangle fits inside`: Output whether or not a rectangle fits inside of another rectangle given the width and height lengths.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the same name as for the benchmark file? That would be fitsinside.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Sorry took me a couple days to see this.

@sampsyo
Copy link
Owner

sampsyo commented Sep 7, 2023

Great; thanks!

@sampsyo sampsyo merged commit 5ff0a3c into sampsyo:main Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants