Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorization/simd benchmark #266

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Add vectorization/simd benchmark #266

merged 6 commits into from
Aug 30, 2023

Conversation

he-andy
Copy link
Contributor

@he-andy he-andy commented Aug 30, 2023

No description provided.

@sampsyo
Copy link
Owner

sampsyo commented Aug 30, 2023

Looks good overall. Would you mind if I nitpicked the name? simd might not stand the test of time, because many benchmarks could potential exercise SIMD execution. Maybe something like vsmul, standing for "vector/scalar multiply"?

@he-andy
Copy link
Contributor Author

he-andy commented Aug 30, 2023

Looks good overall. Would you mind if I nitpicked the name? simd might not stand the test of time, because many benchmarks could potential exercise SIMD execution. Maybe something like vsmul, standing for "vector/scalar multiply"?

Makes sense, updated the PR with the new name

Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some cleanup is required in the docs.

docs/tools/bench.md Outdated Show resolved Hide resolved
docs/tools/bench.md Outdated Show resolved Hide resolved
bril-rs/rs2bril/README.md Outdated Show resolved Hide resolved
@he-andy
Copy link
Contributor Author

he-andy commented Aug 30, 2023

Looks like some cleanup is required in the docs.

Fixed these, thanks for the feedback!

@sampsyo
Copy link
Owner

sampsyo commented Aug 30, 2023

Looks good; thanks!

@sampsyo sampsyo merged commit 38c867f into sampsyo:main Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants