Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim swap files to gitignore and a Euler's number approximation benchmark #264

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

keikun555
Copy link

No description provided.

@keikun555
Copy link
Author

Forgot to make changes to the benchmark documentation, let me add that

@keikun555
Copy link
Author

Done

@keikun555 keikun555 changed the title Add vim swap files to gitignore and a Euler approximation benchmark using Taylor series Add vim swap files to gitignore and a Euler's number approximation benchmark Aug 30, 2023
Copy link
Owner

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Here's just a minor suggestion for the .gitignore change. (The benchmark looks fine!)

.gitignore Outdated

# vim swap files
*.sw*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this, to make it potentially less of a surprise for other extensions?

Suggested change
*.sw*
*.swp
*.swo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken in the suggestions

Kei Imada added 3 commits August 30, 2023 10:22
@sampsyo
Copy link
Owner

sampsyo commented Aug 30, 2023

Looks good; thanks!!

@sampsyo sampsyo merged commit c34372a into sampsyo:main Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants