reverse_int #262
Merged
reverse_int #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Aug 30, 2023
benchmarks/core/reverse.bril
Outdated
| @@ -0,0 +1,31 @@ | |||
|
|
|||
| @main{ | |||
| input: int = const 123; | |||
There was a problem hiding this comment.
This is OK, but to make the benchmark a little more reusable, you might consider making the input a parameter. Here's an example:
bril/benchmarks/core/armstrong.bril
Lines 1 to 2 in a7a0759
That is, you can make input a parameter to @main and then give it a value like # ARGS: 123 for benchmark automation purposes.
|
Hmm… it looks like this may have erroneously reformatted the whole |
|
ooops it seems that it autoformats when I save the file. I have pushed a fix. @sampsyo |
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverse the integer
e.g. 123 -> 321