-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ne, eq, fix fold bug. #106
Conversation
Address #99 . Case A
=>
Case B
=>
Case C
=>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great! What do you think about adding your test cases from the issue body as test files herein?
Co-authored-by: Adrian Sampson <[email protected]>
Co-authored-by: Adrian Sampson <[email protected]>
Is there some place specifically LVN is tested? |
Ah yeah, good point: I have them here. https://github.com/sampsyo/bril/tree/master/examples/test/lvn |
Thanks! Didn't see those. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wahoo; perfect! Thanks!!
bril2json < comparisons.bril | python3 examples/lvn.py -p -c -f | bril2txt
=>
Initially this was not folding since
const == False
.