Support much more type comment tags. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From v4.3 update, below type comment tags being supported. Also, in the `bigint` case, it can use `@type uint64` comment tag for `unsigned bigint` restriction.
For reference, such type comment tags are designed to prepare the next v5 update, Protocol Buffer supporting.
- `@type {string}`
- `int`: `Math.floor(x) === x`
- `uint`: `Math.floor(x) === x && x >= 0`
- `int32`: `-2^31 <= x <= 2^31 - 1`
- `uint32`: `0 <= x <= 2^32 - 1`
- `uint64`: `0 <= x <= 2^64 - 1`
- `int64`: `-2^63 <= x <= 2^63 - 1`
- `float`: `-1.175494351e38 <= x <= 3.4028235e38`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v4.3 update, below type comment tags being supported.
Also, in the
bigintcase, it can use@type uint64comment tag forunsigned bigintrestriction.For reference, such type comment tags are designed to prepare the next v5 update, Protocol Buffer supporting.
@type {string}int:Math.floor(x) === xuint:Math.floor(x) === x && x >= 0int32:-2^31 <= x <= 2^31 - 1uint32:0 <= x <= 2^32 - 1uint64:0 <= x <= 2^64 - 1int64:-2^63 <= x <= 2^63 - 1float:-1.175494351e38 <= x <= 3.4028235e38