From 77f268983e1e6446acedeed0e30edb9a4c538335 Mon Sep 17 00:00:00 2001
From: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
Date: Thu, 18 Jan 2024 14:08:30 +0530
Subject: [PATCH] misc: optimize by avoiding repetitive code

Added a list of testcases to iterate over and to avoid repetition.
Also removed unnecessary print statement.

Signed-off-by: Shwetha K Acharya <Shwetha.K.Acharya@ibm.com>
---
 testcases/misc/test_dbm.py |  7 ++++---
 testcases/misc/test_io.py  | 20 +++++++++++---------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/testcases/misc/test_dbm.py b/testcases/misc/test_dbm.py
index 00feaaf..141bbee 100755
--- a/testcases/misc/test_dbm.py
+++ b/testcases/misc/test_dbm.py
@@ -94,9 +94,10 @@ def _check_dbm_consistency(base: Path, nrecs: int) -> None:
 def _run_dbm_consistency_checks(base_path: Path) -> None:
     base_path.mkdir(parents=True, exist_ok=True)
     try:
-        _check_dbm_consistency(base_path, 10)
-        _check_dbm_consistency(base_path, 100)
-        _check_dbm_consistency(base_path, 10000)
+        test_sizes = [10, 100, 10000]
+
+        for size in test_sizes:
+            _check_dbm_consistency(base_path, size)
     finally:
         shutil.rmtree(base_path, ignore_errors=True)
 
diff --git a/testcases/misc/test_io.py b/testcases/misc/test_io.py
index 7ecc8db..65b9846 100755
--- a/testcases/misc/test_io.py
+++ b/testcases/misc/test_io.py
@@ -104,17 +104,19 @@ def _run_checks(dsets: typing.List[DataPath]) -> None:
 def _check_io_consistency(test_dir: Path) -> None:
     base = None
     try:
-        print("\n")
         base = test_dir / "test_io_consistency"
         base.mkdir(parents=True)
-        # Case-1: single 4K file
-        _run_checks(_make_datasets(base, 4096, 1))
-        # Case-2: single 16M file
-        _run_checks(_make_datasets(base, 2**24, 1))
-        # Case-3: few 1M files
-        _run_checks(_make_datasets(base, 2**20, 10))
-        # Case-4: many 1K files
-        _run_checks(_make_datasets(base, 1024, 100))
+
+        test_cases = [
+            (4096, 1),  # Case-1: single 4K file
+            (2**24, 1),  # Case-2: single 16M file
+            (2**20, 10),  # Case-3: few 1M files
+            (1024, 100),  # Case-4: many 1K files
+        ]
+
+        for size, count in test_cases:
+            datasets = _make_datasets(base, size, count)
+            _run_checks(datasets)
     except Exception as ex:
         print("Error while executing test_io_consistency: %s", ex)
         raise