Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from configmap for leader election to lease #234

Open
phlogistonjohn opened this issue Aug 4, 2022 · 1 comment
Open

Switch from configmap for leader election to lease #234

phlogistonjohn opened this issue Aug 4, 2022 · 1 comment

Comments

@phlogistonjohn
Copy link
Collaborator

Since we already don't support older k8s versions it probably makes more sense to use the new dedicated resource type.
@phlogistonjohn phlogistonjohn changed the title Switch from confimmap for leader election to lease Switch from configmap for leader election to lease Aug 5, 2022
@phlogistonjohn
Copy link
Collaborator Author

Looks like controller-runtime sets this as the default in version v0.12.0:
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.12.0

I'm pretty sure we could override this on the version we currently use. But this could be one reason to consider updating this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SINK project
Status: Idea
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phlogistonjohn