Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding fastwebsockets as an option #651

Open
AdrianEddy opened this issue Jan 18, 2024 · 2 comments
Open

Consider adding fastwebsockets as an option #651

AdrianEddy opened this issue Jan 18, 2024 · 2 comments

Comments

@AdrianEddy
Copy link

Is your feature request related to a problem? Please describe.
It would be nice to have an option to select fastwebsockets as a feature instead of tungstenite

Describe the solution you'd like
Add fastwebsockets alternative to tungstenite as a cargo feature

Describe alternatives you've considered
I could use hyper directly with fastwebsockets but salvo's interface is much nicer

@chrislearn
Copy link
Member

I feel like adding fastwebsockets may make the default websocket implementation more complex.

The types of fastwebsockets and tungstenite should not be universal, which will lead to completely different interfaces exposed to the public by default. This is not as good as externally implementing a separate middleware to support fastwebsockets.

@AdrianEddy
Copy link
Author

got it, would it maybe make sense to add it to examples/ with the usage as a middleware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants