Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu 14.04, default hhvm pid file path incorrect #65

Open
cybacolt opened this issue Oct 27, 2015 · 3 comments
Open

ubuntu 14.04, default hhvm pid file path incorrect #65

cybacolt opened this issue Oct 27, 2015 · 3 comments

Comments

@cybacolt
Copy link
Member

from /etc/init.d/hhvm:
PIDFILE=/var/run/hhvm/pid

from the php formula map php/ng/map.jinja:
('pid', '/var/run/hhvm.pid'),

this causes hhvm not to start by default unless you add to your pillar:

  ng:
    lookup:
      hhvm:
        server:
          pid: '/var/run/hhvm/pid'

not sure if this is easily changable - other distros may break if your change the default pid pathing?

@gravyboat
Copy link
Contributor

Seems like something that we should add to the map.jinja for each distro, then merge that with the pillar data.

Edit: Actually it looks like that was already done, Is this not getting merged correctly or something?

@cybacolt
Copy link
Member Author

yeah, it its mapping per distro, but the value is still wrong for 'Debian'

@gravyboat
Copy link
Contributor

I'd say prep a PR for the debian fix then, could have been someone just copy pasta'd it in an effort to save time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants