add monthly seasonality #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add windstats_monthly.py
update comments in windstats_monthly.py
Emerald01
requested changes
Jun 4, 2024
There was a problem hiding this comment.
@shi-yu-wang
I approved the PR but you may need to fix the PR tests
Hi @Emerald01, thank you for the response. I have looked into the unitest, which includes https://github.com/salesforce/Merlion/blob/main/tests/anomaly/test_dpad.py. It seems that this test does not use the code to be merged (windstats_monthly.py) at all. Instead, it calls DeepPointAnomalyDetector and DeepPointAnomalyDetectorConfig. I'm not sure if the failure is associated the feature to be merged. Could you double check this? Many thanks! All the best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added windstats_monthly.py to include monthly seasonality to windstats.py.