New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the ngrok if app installation failed #717

Open

2can wants to merge 1 commit into main from tunnel

Contributor

2can commented Jan 2, 2024

I want to merge this PR because

it stops the ngrok in case of failed app installation
it fixes the the output URLs
it improves output messages

Related (issues, PRs, topics)

#714

Steps to test feature

saleor app tunnel --force-install

I have:

Tested it locally and it doesn't break existing features
Added documentation if public changes are introduced
Added tests for my code


          Close the ngrok if app installation failed

b5fdda6

2can requested review from zaiste and removed request for zaiste

January 2, 2024 12:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet