Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max length for domain name validation #716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2can
Copy link
Contributor

@2can 2can commented Dec 22, 2023

I want to merge this PR because

  • it changes the domain length validation to 150 chars

Related (issues, PRs, topics)

  • #715

Steps to test feature

  • `saleor env create --domain some-pretty-long-domain-name-for-validation'

I have:

  • Tested it locally and it doesn't break existing features
  • Added documentation if public changes are introduced
  • Added tests for my code

@2can 2can requested a review from zaiste January 2, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant