Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant modulo operation in vector_modn_dense #38835

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Remove redundant modulo operation in vector_modn_dense #38835

wants to merge 3 commits into from

Conversation

user202729
Copy link
Contributor

Just a tiny change. There's no user-visible behavior seen.

(The output of int(…) is already reduced modulo p anyway.)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Documentation preview for this PR (built with commit c97a639; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim requested changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two extra little things. Otherwise I think this is good to go.

src/sage/modules/vector_modn_dense.pyx Show resolved Hide resolved
src/sage/modules/vector_modn_dense.pyx Outdated Show resolved Hide resolved
@user202729 @tscrim
Apply suggestions from code review
c97a639 
Co-authored-by: Travis Scrimshaw <[email protected]>
tscrim
tscrim approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Positive review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

@fchapoton fchapoton fchapoton left review comments

Assignees
No one assigned
Labels
s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user202729 @tscrim @fchapoton