fix: swap & stake decoding was displayed twice #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decoding in the SignOrExecuteForm was displayed twice for stake and swap txs.
Branch preview✅ Deploy successful! Storybook: |
compojoom
changed the title
compojoom
changed the title
usame-algan
approved these changes
Oct 7, 2024
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1498 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 9564a91 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
I was originally fixing a bug with staking decoding being displayed twice:
But actually it turned out to be also the same for swaps:
Resolves #
We introduced this bug with the redesign of the tx-details: fced301 . We moved the TxData block higher up in the tree, but failed to account that we display the same info with the ConfirmationOrder view. So this block should be hidden if we are dealing with a stake or swap txs.
How this PR fixes it
If we have any kind of StakingTxInfo or OrderTxInfo tx we hide the TxData block.
How to test it
Create a swap or stake tx. Sign it. Now in the tx queue hit execute. In production right now we display nearly the same data twice, with this fix only the appropriate confirmation view data is displayed.
Screenshots
Checklist