Tests: add component tests for tx history filter #3758
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show new covered files 🐣
Test suite run success1477 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 579c701 |
| const amountInput = | ||
| screen.getByTestId('amount-input').querySelector('input') ?? | ||
| (() => { | ||
| throw new Error('Input element not found') |
There was a problem hiding this comment.
why are you throwing here? On the next line you expect this element to be in the document?
There was a problem hiding this comment.
I had the error Type 'null' is not assignable to type 'Element | Node | Document | Window'.ts(2345) which was solved by adding that statement.
There was a problem hiding this comment.
you can do:
const amountInput = screen.getByTestId('amount-input').querySelector('input') as HTMLInputElement
this forced typescript to treat the amountinput as HtmlInputElement and it won't show you the ts error. Since you are checking that the element is in the document and if it isn't the test fails anyway I think that this a better way.
There was a problem hiding this comment.
changed, thank you for feedback
What it solves
Resolves #3759
How this PR fixes it
How to test it