Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: add Spindl #2842

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Analytics: add Spindl #2842

merged 4 commits into from
Nov 22, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Add a new tracking script from Spindl in lite mode (cookie-less). It will be initialized on page load along with GTM.

Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://spindl--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 21, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 21, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +4.15 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Nov 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.96% 10019/13190
🔴 Branches 50.12% 2040/4070
🔴 Functions 58.76% 1496/2546
🟡 Lines 77.53% 9054/11678

Test suite run success

1098 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from e2c4bbf

@katspaugh katspaugh added this to the 1.3.0 milestone Nov 21, 2023
@katspaugh katspaugh marked this pull request as draft November 21, 2023 21:03
@francovenica
Copy link
Contributor

a bit lost in this ticket. Is a draft so I assume there is more work to be done.
I cannot find anything in the dev console about spindl to see if the script is being loaded or not

@katspaugh katspaugh marked this pull request as ready for review November 22, 2023 09:23
@katspaugh
Copy link
Member Author

It's now ready for QA.

@liliya-soroka
Copy link
Member

A few comments:

  1. page_view - I did not find a way to see the whole URL to check it . Maybe we can add pagePath?
  2. my macOS version is detected incorrectly for some reason ( 10.15.7 instead of 14.1.1)
  3. Are we planning to add a connected wallet label in the future?

Otherwise

  1. Page_view is triggered on each page opening
  2. Wallet_connected is triggered on wallet connection ( MM, Ledger, WC)

@katspaugh
Copy link
Member Author

The URL is just truncated in the logs visually, the path is there.

Are we planning to add a connected wallet label in the future?

Yes.

@katspaugh katspaugh merged commit d81cd0c into dev Nov 22, 2023
15 checks passed
@katspaugh katspaugh deleted the spindl branch November 22, 2023 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants