Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Next 13 - useRouter() -> usePathName(), useParams() #2478

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix: Next 13 - useRouter() -> usePathName(), useParams() #2478

merged 2 commits into from
Aug 31, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Fixes #2462 (comment)

In Next 13, we cannot use useRouter from the App component.

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_router--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh requested review from usame-algan and iamacook and removed request for iamacook August 31, 2023 11:20
@katspaugh katspaugh requested review from schmanu and removed request for usame-algan and iamacook August 31, 2023 11:33
@katspaugh katspaugh merged commit 7b294ea into dev Aug 31, 2023
9 checks passed
@katspaugh katspaugh deleted the fix-router branch August 31, 2023 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
schmanu
schmanu reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@schmanu schmanu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I navigate to any of my Safes in the sidebar from the welcome page and then click "New Transaction" the modal does not open.
I need to click the button twice now.
Edit: Unrelated to this change. But also present on the release deployment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmanu schmanu schmanu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katspaugh @schmanu