Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust decoded tx ui #2235

Merged
merged 4 commits into from
Jul 6, 2023
Merged

fix: Adjust decoded tx ui #2235

merged 4 commits into from
Jul 6, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Uses the compact prop to display DecodedTxs with the alternative design

How to test it

  1. Open a Safe
  2. Create a multisend transaction
  3. Observe the new design
  4. Navigate to the history and expand a multisend transaction
  5. Observe that it still looks like it used to

Screenshots

Screenshot 2023-07-05 at 16 17 59 Screenshot 2023-07-05 at 16 18 19

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from schmanu July 5, 2023 14:18
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Branch preview

✅ Deploy successful!

https://decoded_ui--walletweb.review-wallet-web.5afe.dev

@@ -44,7 +44,7 @@ const TxStatusWidget = ({
return (
<Paper>
<div className={css.header}>
<SafeLogo width={32} height={32} />
<SafeLogo width={32} height={32} className={css.logo} />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a regression so I fixed it here

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but the DecodedTx unit test is failing.

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it once again and realized that the hover and expanded state border looks a bit weird:
Screenshot 2023-07-05 at 16 50 51
Screenshot 2023-07-05 at 16 50 38

@usame-algan usame-algan requested a review from schmanu July 6, 2023 08:49
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looking good now!

@usame-algan usame-algan merged commit 58291de into epic-tx-flow Jul 6, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the decoded-ui branch July 6, 2023 11:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants