-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TxFlow submit button alignment, error message spacing #2227
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to do the same for the SignForm
as well.
<ErrorMessage error={submitError}>Error submitting the transaction. Please try again.</ErrorMessage> | ||
) | ||
{hasError && ( | ||
<div className={css.errorWrapper}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's better or worse but if you pass the className
to the ErrorMessage
components, you need not create the hasError
flag. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I didn't see that we could already pass a className
to ErrorMessage
. Lets do it that way so we can remove hasError
.
What it solves
Part of #2067
How this PR fixes it
How to test it
Screenshots
Checklist