Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TxFlow submit button alignment, error message spacing #2227

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2067

How this PR fixes it

  • Aligns the submit button to the right at all times
  • Adds spacing above error messages

How to test it

  1. Open a Safe
  2. Confirm an existing transaction
  3. Switch to a wallet thats not an owner
  4. Observe the Submit button still aligned to the right
  5. Create a transaction that will fail
  6. Observe enough space above the error message

Screenshots

Screenshot 2023-07-04 at 16 49 38 Screenshot 2023-07-04 at 16 49 55

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from iamacook July 4, 2023 14:50
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Branch preview

✅ Deploy successful!

https://ui_issues--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do the same for the SignForm as well.

<ErrorMessage error={submitError}>Error submitting the transaction. Please try again.</ErrorMessage>
)
{hasError && (
<div className={css.errorWrapper}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's better or worse but if you pass the className to the ErrorMessage components, you need not create the hasError flag. What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't see that we could already pass a className to ErrorMessage. Lets do it that way so we can remove hasError.

@usame-algan usame-algan requested a review from iamacook July 5, 2023 08:25
@usame-algan usame-algan merged commit 6b19bac into epic-tx-flow Jul 5, 2023
7 checks passed
@usame-algan usame-algan deleted the ui-issues branch July 5, 2023 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants