Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert Ledger module #2215

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: revert Ledger module #2215

merged 1 commit into from
Jul 3, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 3, 2023

What it solves

Direct Ledger connection

How this PR fixes it

The @web3-onboard/ledger module has been reverted to no longer rely on Ledger Live, supporting more chains and custom derivation paths.

How to test it

Open the Safe on a chain that supports Ledger devices and connect and transact successfully.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh July 3, 2023 08:45
@iamacook iamacook self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Branch preview

✅ Deploy successful!

https://revert_ledger--walletweb.review-wallet-web.5afe.dev

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good. I was able to connect just fine and execute tx as well. Tested it in Eth and Poly

@iamacook iamacook merged commit d4885e1 into dev Jul 3, 2023
6 of 7 checks passed
@iamacook iamacook deleted the revert-ledger branch July 3, 2023 12:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants