Refactor SignOrExecuteForm

[compojoom]

The recent bug in the SignOrExecuteForm #4325 showed that we need to investigate how to refactor it and how to increase the test coverage. This bug has been live in production for the past 2 months and we only now noticed.

We should figure out if there is a better way to display custom decoding per type. The confirmation order views are very similar

to the tx Details

but still not the same.

        {decodedData && (
          <ErrorBoundary fallback={<></>}>
            <ConfirmationOrder decodedData={decodedData} toAddress={safeTx?.data.to ?? ''} />
          </ErrorBoundary>
        )}

The ConfirmationOrder component is only going to render if we are dealing with a Stake or Swap tx. But then in order not to duplicate the information we have

{showTxDetails && <TxData txDetails={txDetails} imitation={false} trusted />}

showTxDetails is defined as

  const showTxDetails =
    props.txId &&
    txDetails &&
    !isCustomTxInfo(txDetails.txInfo) &&
    !isAnyStakingTxInfo(txDetails.txInfo) &&
    !isOrderTxInfo(txDetails.txInfo)

If we now introduce more custom decodings we will need to exclude them in the showTxDetails which I'm sure we are going to forget to do.