Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eip1193Provider instead of onboard for dispatch calls #3744

Closed
usame-algan opened this issue May 24, 2024 · 1 comment · Fixed by #3745
Closed

Use Eip1193Provider instead of onboard for dispatch calls #3744

usame-algan opened this issue May 24, 2024 · 1 comment · Fixed by #3745
Assignees

Comments

@usame-algan
Copy link
Member

usame-algan commented May 24, 2024

Description

Transaction dispatch calls are tightly coupled with onboard even though they are low-level functions and only need a standard Eip1193Provider. They also handle chain switching in case the wallet is on a different chain than the safe. This will be tackled as part of #3743

The goal is to not rely on our custom useOnboard state anymore but instead either switch to a different wallet solution or start using pre-defined hooks that onboard provides.

Requirements

  • All dispatch functions should expect a Eip1193Provider instead of an onboard object
  • Extract the assertWalletChain calls to switch the chain higher up the call tree to the components calling the dispatch functions
@liliya-soroka
Copy link
Member

Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants