Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended nonce loading is too long #2689

Closed
liliya-soroka opened this issue Oct 24, 2023 · 3 comments
Closed

Recommended nonce loading is too long #2689

liliya-soroka opened this issue Oct 24, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@liliya-soroka
Copy link
Member

Bug description

Recommended nonce loading is too long and it's possible to create a few txs under the same current safe nonce because of it

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Go to the walletconnect native implementation PR
  2. trigger tx from the dapp
    Current result:The suggested nonce is still being loaded while the sign button is already available. As the result it's possible to create tx with the safe current nonce instead of the next one in the queue
Screen.Recording.2023-10-24.at.17.04.56.mov
  1. go to the queue list
  2. click confirm tx
    Current result: The tx nonce has been in a loading state for a long time. It's quite strange as the nonce is known for the tx from the queue list
    https://github.com/safe-global/safe-wallet-web/assets/338622/77efb27d-2792-439f-8049-97218300f21d

Expected result

Could we check why the nonce loading is taking so much time?

@liliya-soroka liliya-soroka added the bug Something isn't working label Oct 24, 2023
@katspaugh
Copy link
Member

I've seen this too, and thought the nonce would never load. But it did, in a few long seconds.
Doubt it's related to WalletConnect though. Most likely a backend issue.

@liliya-soroka
Copy link
Member Author

I think the recommended nonce loading time depends on the number of transactions in the queue. The longer queued txs list , the longer it takes to receive a response.

@katspaugh
Copy link
Member

@liliya-soroka this will be solved here: safe-global/safe-client-gateway#681
I'll close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants