-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tx flow] Errors should be cards #2288
Comments
Hi @iamacook I'll like to work on this task |
@ElizabethOgbee, I'd suggest tackling issues labelled as "good first issue" instead. We are still actively developing this. |
I think, errors alerts should belong to the relevant places in the UI. This particular error is displayed before a user is about to confirm or execute a transaction, so it makes sense that it is a part of this block. |
Good point, closing then. 👍 |
Bug description
The errors shown in the sign/execute areas are currently "embedded" in parent cards, but they should be their own top-level ones.
Steps to reproduce
Expected result
The error is it's own "top-level" card.
Obtained result
Errors are embedded within cards.
Screenshots
Current:
Desired:
The text was updated successfully, but these errors were encountered: