Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tx flow] Errors should be cards #2288

Closed
iamacook opened this issue Jul 13, 2023 · 5 comments
Closed

[Tx flow] Errors should be cards #2288

iamacook opened this issue Jul 13, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@iamacook
Copy link
Member

Bug description

The errors shown in the sign/execute areas are currently "embedded" in parent cards, but they should be their own top-level ones.

Steps to reproduce

  1. Connect to a Safe as a non-owner.
  2. Try to create a transaction.
  3. Observe the error.

Expected result

The error is it's own "top-level" card.

Obtained result

Errors are embedded within cards.

Screenshots

Current:

image

Desired:

image

@iamacook iamacook added the bug Something isn't working label Jul 13, 2023
@ElizabethOgbee
Copy link

Hi @iamacook I'll like to work on this task

@iamacook
Copy link
Member Author

iamacook commented Jul 25, 2023

Hi @iamacook I'll like to work on this task

@ElizabethOgbee, I'd suggest tackling issues labelled as "good first issue" instead. We are still actively developing this.

@schmanu schmanu assigned schmanu and unassigned schmanu Aug 10, 2023
@liliya-soroka
Copy link
Member

@TanyaEfremova
Copy link
Contributor

I think, errors alerts should belong to the relevant places in the UI. This particular error is displayed before a user is about to confirm or execute a transaction, so it makes sense that it is a part of this block.

@katspaugh
Copy link
Member

Good point, closing then. 👍

@katspaugh katspaugh closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants