Fix runOp Script
#435
Merged
Fix runOp Script
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running the 4337 `runOp.ts` script this morning and noticed it was subtly broken. This PR fixes it.
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
I think I wrote the |
|
I use it to send a user operation to an actual chain (Sepolia in my case). It is still convenient IMO. |
mmv08
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running the 4337
runOp.tsscript this morning and noticed it was subtly broken. This PR fixes it.I also refactored the scripts a bit - specifically we no longer
--fixonlint:ts. This was because it would cause CI to silently pass in cases where the linter could autofix the code (when we want it to fail instead).