-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daimo deployment update #481
Comments
nlordell
added a commit
that referenced
this issue
Aug 14, 2024
Fixes #481 Some contracts included in our deployment script are expected to use the Arachnid CREATE deployment proxy instead of the Safe singleton factory. We change our deployment scripts to manually use the Arachnid CREATE2 deployer in those specific cases, so the contracts end up at the expected addresses. Affected contracts: - ERC-4337 entry point - Daimo P-256 verifier
remedcu
pushed a commit
that referenced
this issue
Aug 15, 2024
Fixes #481 Some contracts included in our deployment script are expected to use the Arachnid CREATE deployment proxy instead of the Safe singleton factory. We change our deployment scripts to manually use the Arachnid CREATE2 deployer in those specific cases, so the contracts end up at the expected addresses. Affected contracts: - ERC-4337 entry point - Daimo P-256 verifier You can verify this works by running `pnpm run deploy hardhat` in the Passkey package and checking the deployment addresses are what you expect them to be: ``` ... deploying "EntryPoint" (tx: 0x58b5726a3381344205508251ec394b4bf74b6f8bc669be0b1c9de8d75ce1f8ef)...: deployed at 0x0000000071727De22E5E9d8BAf0edAc6f37da032 with 3650209 gas ... deploying "DaimoP256Verifier" (tx: 0xe18ff421fb23f117cdb2e60917f68703459743d0a26a14b79eae2cc01def4a20)...: deployed at 0xc2b78104907F722DABAc4C69f826a522B2754De4 with 814337 gas ... deploying "SafeWebAuthnSignerFactory" (tx: 0x3e6df468f44301ff0bd64fd2403a42214417e25eb865a3c8cb68c79cc5ce042f)...: deployed at 0x1d31F259eE307358a26dFb23EB365939E8641195 with 1031063 gas deploying "SafeWebAuthnSharedSigner" (tx: 0xc9d5201f64e0f0d537870bafb8a6445c70970f3a13fdda763eee0cb0519bfbf9)...: deployed at 0x94a4F6affBd8975951142c3999aEAB7ecee555c2 with 690536 gas ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest version of the
passkey
module usessafe-singleton-factory
for deployment, but we use the official deployment from here which uses the Deterministic method.This issue captures the work for deploying Daimo with the Deterministic approach while keeping the rest of the deployment as it is (Daimo should not be deployed twice, just once with the Deterministic approach).
More context: #477 (comment)
The text was updated successfully, but these errors were encountered: