Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Metering ERC20 Paymaster Script Sometimes Fails #480

Open
nlordell opened this issue Aug 13, 2024 · 2 comments
Open

Gas Metering ERC20 Paymaster Script Sometimes Fails #480

nlordell opened this issue Aug 13, 2024 · 2 comments

Comments

@nlordell
Copy link
Collaborator

Description

Originally posted in #478 (review)

The ERC20 paymaster gas metering script does not always fund enough. In particular, it funds the account with 1.0 USDC, but in a recent run, the paymaster required a debit of ~1.8 USDC.

We should change the metering script to be more resilient to changing gas prices and potentially fund the contract more when needed.

@mmv08
Copy link
Member

mmv08 commented Aug 19, 2024

I wanted to do this the last time I worked on benchmarking, but there was no method in Pimlico API for this. I didn't want to spend much time on it and haven't looked into how exactly Pimlico calculates the fee, and they didn't get back to my question: https://5afe.slack.com/archives/C05JA2HFQ1J/p1716898280881779

This may be a little effort because you'll have to read the source code. (Also we don't really run benchmarks that often so maybe a configuration option is sufficient)

@remedcu
Copy link
Member

remedcu commented Aug 19, 2024

(Also we don't really run benchmarks that often so maybe a configuration option is sufficient)

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants