[4337] Some tests do not actually test what they claim to test

[mmv08]

Description

Some tests like

safe-modules/modules/4337/test/erc4337/ERC4337ModuleExisting.spec.ts

Lines 49 to 70 in b8568dd

	it('should execute contract calls without a prefund required', async () => {
	const { user1, safe, validator, entryPoint, relayer } = await setupTests()
	await entryPoint.depositTo(await safe.getAddress(), { value: ethers.parseEther('1.0') })
	await user1.sendTransaction({ to: await safe.getAddress(), value: ethers.parseEther('0.5') })
	const safeOp = buildSafeUserOpTransaction(
	await safe.getAddress(),
	user1.address,
	ethers.parseEther('0.5'),
	'0x',
	'0',
	await entryPoint.getAddress(),
	false,
	false,
	)
	const safeOpHash = calculateSafeOperationHash(await validator.getAddress(), safeOp, await chainId())
	const signature = buildSignatureBytes([await signHash(user1, safeOpHash)])
	const userOp = buildUserOperationFromSafeUserOperation({ safeOp, signature })
	await logGas('Execute UserOp without a prefund payment', entryPoint.handleOps([userOp], relayer))
	expect(await ethers.provider.getBalance(await safe.getAddress())).to.be.eq(ethers.parseEther('0'))
	})

do not test what the test description says. This test should test if the module can execute contract calls while the operation it tests is a native token transfer. Theoretically, I might be able to hardcode the call data passed to execTransactiomFromModule, and the test would still pass.

Proposed solution

There are multiple solutions to this, and the implementer should evaluate them:

1. See if we have enough coverage for the problem I outlined through other tests, and if that's true, adjust the test description
2. Alternatively, implement additional tests and adjust the test description