Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDC_NETWORK not added to MASTER_COPIES and PROXY_FACTORIES in addresses.py #896

Closed
Satishpethani92 opened this issue Apr 12, 2024 · 1 comment

Comments

@Satishpethani92
Copy link

Satishpethani92 commented Apr 12, 2024

In the commit 4672097 on January 23rd, the XINFIN_XDC_NETWORK constant was updated to XDC_NETWORK in the ethereum_network.py file. However, the corresponding change was not made in the safe/addresses.py file.

In safe/addresses.py, the XINFIN_XDC_NETWORK was removed from the MASTER_COPIES and PROXY_FACTORIES dictionaries, but it was not replaced with XDC_NETWORK. As a result, the library is unable to trace transactions on the XDC Network.

To resolve this issue, the following changes should be made in safe/addresses.py:

  1. Add XDC_NETWORK to the MASTER_COPIES dictionary with the appropriate master copy address for the XDC Network.

  2. Add XDC_NETWORK to the PROXY_FACTORIES dictionary with the correct proxy factory address for the XDC Network.

By making these changes, the safe-eth-py library will be able to properly trace transactions on the XDC Network.

Please update the safe/addresses.py file to include the XDC_NETWORK constant in the MASTER_COPIES and PROXY_FACTORIES dictionaries, ensuring consistency with the changes made in ethereum_network.py.

@Uxio0
Copy link
Member

Uxio0 commented Apr 12, 2024

As we were having multiple issues adding addresses we added a new workflow for that, please use that template: https://github.com/safe-global/safe-eth-py/issues/new/choose

Sorry for the inconvenience

@Uxio0 Uxio0 closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants