Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor etherscan client #887

Closed
moisses89 opened this issue Apr 8, 2024 · 1 comment
Closed

Refactor etherscan client #887

moisses89 opened this issue Apr 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@moisses89
Copy link
Member

What is needed?

Currently etherscan client require to configure two identicatl URLS.

safe-eth-py/gnosis/eth/clients/etherscan_client.py

Line 24 in 324a5d0

NETWORK_WITH_URL = {

safe-eth-py/gnosis/eth/clients/etherscan_client.py

Line 66 in 324a5d0

NETWORK_WITH_API_URL = {

I'd say remove the API extension and leave the ETHERSCAN_URL like is in BlockScoutClient
@moisses89 moisses89 added the enhancement New feature or request label Apr 8, 2024
@Uxio0
Copy link
Member

Uxio0 commented Apr 12, 2024

Maybe we can close this, as we discussed that one url is useful to access the API and other for generating links to the block explorer

@Uxio0 Uxio0 closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Uxio0 @moisses89