Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Transaction Service guides #429

Merged
merged 19 commits into from
Apr 11, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

Copy link

github-actions bot commented Apr 5, 2024

Overall readability score: 68.26 (🔴 -0.01)

File Readability
api.md 67.82 (-)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
api.md 67.82 53.78 8.72 8.9 11.34 7.43
  - - - - - -

Averages:

  Readability FRE GF ARI CLI DCRS
Average 68.26 58.65 9.22 9.94 10.82 7.03
  🔴 -0.01 🔴 -0.12 🟢 +0.01 🟢 +0.03 🔴 -0.01 🔴 -0.01
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review April 5, 2024 11:27
@falvaradorodriguez falvaradorodriguez requested review from Uxio0, germartinez, tanay1337 and dasanra and removed request for germartinez and tanay1337 April 5, 2024 11:27
@germartinez germartinez changed the title Add examples for interacting with Tx service docs: Add Transaction Service guides Apr 5, 2024
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, but I left some questions

pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
pages/advanced/api-safe-transaction-service/guides/api.md Outdated Show resolved Hide resolved
@Uxio0
Copy link
Member

Uxio0 commented Apr 11, 2024

Really good job

@Uxio0
Copy link
Member

Uxio0 commented Apr 11, 2024

Please let the team know in #general after this is deployed

@falvaradorodriguez falvaradorodriguez merged commit ea9bc9a into main Apr 11, 2024
3 checks passed
@germartinez germartinez deleted the add-examples-for-interacting-tx-service branch April 11, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples for interacting with tx service on docs.safe.global
5 participants