Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base rpc url; inform about possible tx failure #1983

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Fix base rpc url; inform about possible tx failure #1983

merged 5 commits into from
Aug 24, 2023

Conversation

elgatovital
Copy link
Contributor

@elgatovital elgatovital commented Aug 24, 2023 •
edited
Loading

Handles #1980
Handles #1981
Handles #1982

Changes proposed in this pull request:

  • Extend error handling
  • Inform about possible tx failure
  • Fix crash when coming from background to tx review screen with error state
  • Fix chain base rpc url

@gnosis/mobile-devs

@elgatovital elgatovital self-assigned this Aug 24, 2023
@elgatovital elgatovital marked this pull request as ready for review August 24, 2023 14:28
@elgatovital elgatovital changed the title Inform about possible tx failure Fix base rpc url; Inform about possible tx failure Aug 24, 2023
@elgatovital elgatovital changed the title Fix base rpc url; Inform about possible tx failure Fix base rpc url; inform about possible tx failure Aug 24, 2023
@elgatovital elgatovital merged commit e2971de into master Aug 24, 2023
1 check passed
@elgatovital elgatovital deleted the feature/issue_1982 branch August 24, 2023 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmitryBespalov DmitryBespalov DmitryBespalov approved these changes

@biafra23 biafra23 Awaiting requested review from biafra23

Assignees

@elgatovital elgatovital

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgatovital @DmitryBespalov