Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle insufficient and loading balances errors #1979

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Handle insufficient and loading balances errors #1979

merged 3 commits into from
Aug 24, 2023

Conversation

elgatovital
Copy link
Contributor

@elgatovital elgatovital commented Aug 24, 2023 •
edited
Loading

Handles #1976
Handles #1977
Handles #1978

Changes proposed in this pull request:

  • Show errors when key balance is not sufficient to execute transaction
  • By default select key with the highest balance

@gnosis/mobile-devs

@elgatovital elgatovital self-assigned this Aug 24, 2023
@elgatovital elgatovital merged commit 0feb143 into master Aug 24, 2023
1 check passed
@elgatovital elgatovital deleted the feature/insufficient_balance_handling branch August 24, 2023 08:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmitryBespalov DmitryBespalov DmitryBespalov approved these changes

@biafra23 biafra23 Awaiting requested review from biafra23

Assignees

@elgatovital elgatovital

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elgatovital @DmitryBespalov