Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] recognize limit order type #2049

Closed
DmitryBespalov opened this issue Jul 2, 2024 · 1 comment
Closed

[android] recognize limit order type #2049

DmitryBespalov opened this issue Jul 2, 2024 · 1 comment
Labels
enhancement

Comments

@DmitryBespalov
Copy link
Contributor

Recognize order type 'limit' order. Distinguished by the fullAppData.metadata.orderClass.orderClass property value limit.
DmitryBespalov added a commit that referenced this issue Jul 2, 2024
@DmitryBespalov
GH-2049 changed the display strings based on order types
2f0045b
@DmitryBespalov DmitryBespalov mentioned this issue Jul 2, 2024
Merged
DmitryBespalov added a commit that referenced this issue Jul 2, 2024
@DmitryBespalov
Merge pull request #2050 from safe-global/GH-2049/limit-order-type
03aefa5 
GH-2049 changed the display strings based on order types
@liliya-soroka
Copy link
Member

Moved back
@DmitryBespalov , for some reason Limit order is not recognised in the Queued list but recognized in the history
safe = sep:0x2a73e61bd15b25B6958b4DA3bfc759ca4db249b9 on staging
tx nonce =357

DmitryBespalov added a commit that referenced this issue Jul 5, 2024
@DmitryBespalov
GH-2049 using order naming in the tx list
4dbf5a3
@DmitryBespalov DmitryBespalov mentioned this issue Jul 5, 2024
Merged
DmitryBespalov added a commit that referenced this issue Jul 5, 2024
@DmitryBespalov
Merge pull request #2056 from safe-global/GH-2049/txlist
d4d58e2 
GH-2049 using order naming in the tx list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmitryBespalov @liliya-soroka