Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with statuses and stepper on the tx details page during signing and execution txs #1994

Open
liliya-soroka opened this issue Aug 30, 2023 · 2 comments
Assignees
Labels

Comments

@liliya-soroka
Copy link
Member

Describe the bug
Problem with statuses and stepper on 2nd signing and execution of the tx

Precondition:
safe 2 of N

To Reproduce
1st case

  1. Create tx in the mobile app
  2. Open tx details to sign it as a second owner
  3. Pulldown to update the tx details
    Current result: The second signature disappears from the stepper and "execution is required" is changed to the "confirmation is required"
  4. sign again and try to execute without pulling the updates
  5. click "View tx details" after execution
  6. "your confirmation is required is displayed as a state
  7. pull down to update the tx details
    Current result: Cancelled state is displayed and pulling down will not help in the status updating
    Expected result: The correct state should be displayed when the pull to refresh is used

2nd:

  1. there is a created tx

  2. sign the tx as a second owner
    Current result: the second signature doesn't appear on the tx details without pull down to refresh

  3. Execute tx after pull to refresh for signature updates
    Current result: Pending status has wrong view ( check the design for the ios), execution step disappears from the stepper
    Expected behavior
    Make sure that pending status and stepper looks simular to the ios ( Execute status should not disappear from the stepper) - ios app view

image

Screenshots
https://drive.google.com/file/d/16W4kWllQIJCrfEuik76EO-X4OxFlruoR/view?usp=sharing
https://drive.google.com/file/d/16XCBJ6FTR74xhk5JXV0MeQy3EG9qG07t/view?usp=sharing

Smartphone (please complete the following information):

  • Device: pixel 5
  • Android Version: Android 13
  • App Version 3.9.0 -4039rc

Environment
prod
Additional context
Add any other context about the problem here.

@liliya-soroka liliya-soroka changed the title problem with statuses and stepper on the tx details page problem with statuses and stepper on the tx details page during signing and execution txs Aug 30, 2023
@biafra23 biafra23 self-assigned this Aug 31, 2023
@biafra23
Copy link
Contributor

biafra23 commented Aug 31, 2023

  1. Pulldown to update the tx details
    Current result: The second signature disappears from the stepper and "execution is required" is changed to the > "confirmation is required"

This might be a caching issue on the backend When I look at response from the server it only contains one confirmation. Does iOS add the second confirmation locally?

@liliya-soroka
Copy link
Member Author

liliya-soroka commented Sep 1, 2023

Verified

  1. pull to refresh is required to see confirmation and executed state, but all states are displayed correctly without the issues
  2. pending state looks good in the status block and in the stepper

app version 3.9.0-4056rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants