Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] [ExecTx] Edit Transaction Fee Screen #1932

Open
elgatovital opened this issue May 30, 2023 · 1 comment
Open

[Android] [ExecTx] Edit Transaction Fee Screen #1932

elgatovital opened this issue May 30, 2023 · 1 comment
Assignees

Comments

@elgatovital
Copy link
Contributor

elgatovital commented May 30, 2023

The screen gives user a way to change the fee-related parameters of the transaction to some manual values instead of using automatically estimated values.

The actual fields depend on the transaction type which depends on the supported transaction type of the chain (Chain Info -> features -> EIP-1559)

Figma iOS

  • Legacy Transaction type
    • Nonce
    • Gas limit
    • Gas Price (Gwei)
  • EIP-1559 Transaction type
    • Nonce
    • Gas limit
    • Base Fee
    • Max Priority Fee (or miner’s tip)
    • Max Fee Per Gas (must equal to base fee + max priority fee)
  • Transactions on the Optimism chain have different fee structure and are handled in a separate issue. Some fields will not be editable.

Tooltips for each field

Estimated Fee Price

Link to the help article
https://help.safe.global/en/articles/40837-advanced-transaction-parameters

  • Value depends on the fee structure and can be presented in both native coin value and if price is available then in fiat value as well.

Current CGW settings for the EIP-1559 support on each chain

(10.02.2022) -

PLEASE CHECK ON IF UPDATES ARE AVAILABLE HERE!

Chain Transaction Type
Ethereum EIP1559
Gnosis EIP1559
Polygon Legacy
Binance Smart Chain Legacy
Energy Web Chain Legacy
Arbitrum Legacy
Avalanche EIP1559
Optimism Custom type (based on Legacy) - handled in a separate issue
Goerli EIP1559
Rinkeby EIP1559
Volta Legacy
@liliya-soroka
Copy link
Member

verified, found issues reported separately ( 2 issues)
app version 3.8.0 -3987

Checked:
Edit fees for the network with EIP-1559
Edit fees for the network with Legacy tx type
valid and invalid values were checked for the each field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants