Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write weekly CI that checks that all tokens have the correct number of decimals #67

Open
PaulRBerg opened this issue Sep 25, 2024 · 1 comment
Open

Write weekly CI that checks that all tokens have the correct number of decimals #67

PaulRBerg opened this issue Sep 25, 2024 · 1 comment
Assignees
@smol-ninja @maxdesalle
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Sep 25, 2024 •
edited
Loading

This isn't trivial to implement, but it would be very much worth it to do it — we should write a weekly CI test that checks that all tokens have the correct number of decimals. We should use the Infura API for this (open to recommendations if there's something better out there).

The goal is to prevent accidental listings whereby the token's decimals does not correspond to the actual value.
@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Sep 25, 2024
@smol-ninja
Copy link
Member

We should use the Etherscan API for this

Did you mean alchemy / infura API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

@maxdesalle maxdesalle

Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @maxdesalle